Skip to content

[v13] Fix access to leaf resources#25852

Merged
rosstimothy merged 3 commits intobranch/v13from
bot/backport-25694-branch/v13
May 8, 2023
Merged

[v13] Fix access to leaf resources#25852
rosstimothy merged 3 commits intobranch/v13from
bot/backport-25694-branch/v13

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

Backport #25694 to branch/v13

Updates TestGenerateUserSingleUseCert to test certificate generation
for kube and db resources in a leaf cluster.
The MFA required check added to the Auth server in
#24250 is now
only performed if the `RouteToCluster` indicates that the request
is for the local cluster and not a remote cluster. When the root
cluster checks if mfa is required to a resource in another cluster
it would always return a not found error since the resource didn't
exist in the root backend. This results in the behavior described
in #25619.

This step is now skipped for any resources in another cluster to allow
certificates for remote cluster resources to be generated by the root.
`tsh` detects that a resource is a leaf cluster and will first call
`proto.AuthService/IsMFARequired` on the leaf cluster before requesting
certificates from the root cluster to prevent a user from being
prompted to complete an MFA ceremony if one is not required.

Closes #25619
@github-actions github-actions Bot added backport size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 8, 2023
@r0mant r0mant mentioned this pull request May 8, 2023
3 tasks
@rosstimothy rosstimothy enabled auto-merge May 8, 2023 20:16
@rosstimothy rosstimothy force-pushed the bot/backport-25694-branch/v13 branch from 01e0cdd to 74f941c Compare May 8, 2023 20:46
@rosstimothy rosstimothy added this pull request to the merge queue May 8, 2023
Merged via the queue into branch/v13 with commit 477afba May 8, 2023
@rosstimothy rosstimothy deleted the bot/backport-25694-branch/v13 branch May 8, 2023 21:45
@r0mant r0mant mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants